Add staking cli test

[sahith-narahari]

• Targeted PR against correct branch (see CONTRIBUTING.md)

• Linked to github-issue with discussion and accepted design OR link to spec that describes this work.

• Wrote tests

• Updated relevant documentation (docs/)

• Added entries in PENDING.md with issue #

• rereviewed Files changed in the github PR explorer

---

For Admin Use:

• Added appropriate labels to PR (ex. wip, ready-for-review, docs)
• Reviewers Assigned
• Squashed all commits, uses message "Merge pull request #XYZ: [title]" (coding standards)

[sahith-narahari]

Please don't merge

[aaronc]

Please don't merge

For this you can mark it as a draft again @sahith-narahari

[aaronc]

This looks like a good start. Obviously the helpers still depend on staking, etc. and eventually we'll want to modularize that. Not sure if we should tackle here or in a later PR.

[aaronc]

An easy way to modularize the helpers is to create a file like x/staking/client/cli/test_helpers.go and put TxStakingEditValidator, etc. as a function with *Fixtures as the first param. Ex:

func TxStakingEditValidator(f  *Fixtures, from string, flags ...string) (bool, string, string) {
...

I think these functions can live in the modules they relate to. Would that work?

/cc @anilcse

[sahith-narahari]

An easy way to modularize the helpers is to create a file like x/staking/client/cli/test_helpers.go and put TxStakingEditValidator, etc. as a function with *Fixtures as the first param. Ex:

func TxStakingEditValidator(f  *Fixtures, from string, flags ...string) (bool, string, string) {
...

I think these functions can live in the modules they relate to. Would that work?

/cc @anilcse

This approach should be fine, will try to migrate for a module and update

[sahith-narahari]

@aaronc I migrated tests and respective helpers to corresponding modules as suggested.
I believe it's good to have gaiad commands and keys commands to be in sdk/cli_test for now as they're used in test initialization, but this is definitely something we can modularize in future(any suggestions are welcome)

[aaronc]

This looks good. Nicely modularized!

[aaronc]

@aaronc I migrated tests and respective helpers to corresponding modules as suggested.
I believe it's good to have gaiad commands and keys commands to be in sdk/cli_test for now as they're used in test initialization, but this is definitely something we can modularize in future(any suggestions are welcome)

Okay, we can start with what's simplest for now.