Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify navigation handling #86

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

srenatus
Copy link
Contributor

@srenatus srenatus commented Nov 2, 2015

Fixes

  • missing "active" class for the "Start" page
  • headaches from looking at _includes/navigation.html (and duplication)

Heads up: this will probably make merging branch fr a little more difficult, but I'd say it's worth it.

Before, 'Start' would never get class="active", because the comparison
between "/" (`link.url`) and "/index.html" (`page.url_no_language`)
would fail. Now, "index.html" is stripped from `page.url_no_language`.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant