Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qol revisions: SIMD detection, external zlib, Makefile CXXFLAGS/LDFLAGS #232

Open
wants to merge 34 commits into
base: master
Choose a base branch
from

Conversation

ggraham
Copy link

@ggraham ggraham commented Mar 30, 2024

These commits address:

  1. Architecture detection had an explicit comparison to "Intel" if x86_64, which caused compilation failure on any AMD processor, despite having the requested vector extensions available (SSE2, SSE4.1, AVX, AVX2)
  1. Static compilation against external zlib causes downstream issues and it can also be left to the user to choose the compression library of choice, allowing dynamic library and facilitating use of libkmc_core.a
  • removed static compilation for kmc binary
  • added separate makefile target for static library (libkmc_core.a)
  • added -lz to linker flags
  1. use / rewriting CC in Makefile when the intended compiler is c++ causes implicit compilation issues, changed to CXX where relevant, used flags in LDFLAGS and CXXFLAGS instead of CLINK and CFLAGS to allow appropriate implicit compilation calls in kmc_core/ and kmc_CLI/
  • no longer requires changing CC to g++ (or similar) on make call
  1. remove python binding creation and requirement for pybind11

I am happy to keep this as a fork if these changes break other elements that you regard as essential. I do think it is important to address 1) and 2). 3) is not an essential change but makes the Makefile difficult to work with

@ggraham ggraham changed the title qol revisions qol revisions: SIMD detection, external zlib, Makefile CXXFLAGS/LDFLAGS Mar 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant