Skip to content

Conversation

@jmwample
Copy link
Member

Added specific commits to pull when building psiphon core and apk.

Disabled inconsistent tests in tapdance/dialer_test.go and tdproxy/tapdance_test.go.

Added new encrypted EmbeddedValues.java

Build now successful

@jmwample
Copy link
Member Author

Hold off on merging this, found issue where psiphon is still vendoring the sergeyfrolov/gotapdance repository so this may build success may not be representative.

- mkdir -p $GOPATH/src/github.com/Psiphon-Labs
# Get Specific Psiphon Core Library Release
- git clone https://github.com/Psiphon-Labs/psiphon-tunnel-core.git $GOPATH/src/github.com/Psiphon-Labs/psiphon-tunnel-core
- (cd $GOPATH/src/github.com/Psiphon-Labs/psiphon-tunnel-core && git checkout $PSIPHON_CORE_VERSION -b build-refraction-networking)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears that we previously would clone master branch, but now are cloning build-refraction-networking? Is there a reason for that?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pulls a commit based on an environment variable set in the travis ci online environment. I added this so that there is some consistency around what is being built against. It is just checking it out locally to a branch named build-refraction-networking.

This is actually a question that I have for the psiphon folks, if there are stable releases of this repo I would prefer to use those ( as we are for Psiphon-Labs/psiphon-tunnel-core) but these are configurable to specific commits / tags / releases using env vars in travis now.

This is the same for #23

@sergeyfrolov sergeyfrolov mentioned this pull request Sep 30, 2019
@jmwample jmwample merged commit d6cb372 into master Sep 30, 2019
@jmwample jmwample deleted the travis-build-master branch September 30, 2019 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants