Skip to content

Conversation

@nettee
Copy link
Contributor

@nettee nettee commented Jan 21, 2026

This reverts commit 990c295.

Summary by CodeRabbit

Release Notes

  • Refactor

    • Simplified sandbox execution context and streamlined internal PTC infrastructure services.
    • Replaced template-based prompt generation with inline system prompts for improved efficiency.
    • Updated configuration handling to use a lighter-weight approach.
  • Chores

    • Removed unused dependencies and fixture files.
    • Cleaned up test configurations and outdated template files.

✏️ Tip: You can customize this high-level summary in your review settings.

@linear
Copy link

linear bot commented Jan 21, 2026

@coderabbitai
Copy link

coderabbitai bot commented Jan 21, 2026

Caution

Review failed

The pull request is closed.

📝 Walkthrough

Walkthrough

This PR removes Programmatic Tool Calling (PTC) integration across the API, schema layers, and skill templates. It eliminates PTC services (PtcSdkService, PtcEnvService), removes PTC-related type fields (ptcEnabled, env), deletes template-based prompt rendering infrastructure, and simplifies prompt generation to use static system prompts instead of dynamic rendering.

Changes

Cohort / File(s) Summary
PTC Service Removal
apps/api/src/modules/tool/ptc/ptc-sdk.service.ts, ptc-env.service.ts, index.ts
Deleted PtcSdkService class with buildPtcContext and S3 SDK loading logic; removed PtcEnvService and environment variable provisioning; removed exports from module index
API Service Integration Removal
apps/api/src/modules/skill/skill-engine.service.ts, skill-invoker.service.ts, apps/api/src/modules/tool/tool.module.ts
Removed PTC service injections and initialization; eliminated ptcContext construction and PTCE environment variable injection logic; removed PtcSdkService/PtcEnvService from module imports/exports; simplified buildInvokeConfig to remove ptcContext assignment
Type and Schema Updates
packages/openapi-schema/schema.yml, packages/openapi-schema/src/schemas.gen.ts, packages/openapi-schema/src/types.gen.ts, packages/ai-workspace-common/src/requests/types.gen.ts, packages/request/src/requests/types.gen.ts
Removed ptcEnabled (boolean) and env (object) fields from SandboxExecuteContext across all schema and generated type definitions
Request/Sandbox Updates
packages/agent-tools/src/builtin/sandbox.ts, packages/agent-tools/src/sandbox/index.ts
Removed ptcEnabled field from SandboxExecuteRequest context construction
Prompt Infrastructure Removal
packages/skill-template/src/prompts/prompt-template.ts
Deleted PromptTemplate class with Handlebars template loading, compilation, partial registration, and render logic
Prompt Templates Deletion
packages/skill-template/src/prompts/templates/copilot-agent-system.md, node-agent-system.md, user-prompt.md, partials/ptc-mode.md
Removed comprehensive system prompt templates for copilot/node agents and PTC mode guidance; deleted user prompt template with conditional rendering logic
Prompt Generation Refactoring
packages/skill-template/src/prompts/copilot-agent.ts, node-agent.ts, user-prompt.ts
Replaced template-based prompt rendering with inline static SYSTEM_PROMPT constants; introduced PtcConfig interface replacing PtcContext; removed PromptTemplate dependencies; simplified buildNodeAgentSystemPrompt to return hardcoded prompt
Agent Skill Updates
packages/skill-template/src/skills/agent.ts
Added buildPtcConfig helper to map toolsets; refactored to use ptcConfig instead of ptcContext for system prompt; updated commonPreprocess and metadata handling
Fixture and Export Cleanup
packages/skill-template/src/prompts/fixtures/fal_image.md, nano_banana.md, node-agent.spec.ts, packages/skill-template/src/base.ts, packages/skill-template/src/index.ts
Removed fixture markdown files; deleted test spec for node-agent; removed PtcContext interface and ptcContext property from SkillRunnableConfig; removed node-agent re-export
Dependency Management
packages/skill-template/package.json
Removed handlebars and @types/handlebars dependencies
Configuration Updates
.vscode/launch.json, biome.json
Removed "Debug Current Test File" launch configuration; removed **/.vscode/** and **/specs/** from biome ignore patterns

Estimated code review effort

🎯 4 (Complex) | ⏱️ ~45 minutes

Possibly related PRs

Suggested reviewers

  • mrcfps

Poem

🐰 A rabbit hops through code so neat,
Removing PTC, making things sweet,
Templates gone, prompts now plain,
Static strings take center stage again!
Simpler flows, no more compile,
Hop-hop-hooray, in rabbit style!

✨ Finishing touches
  • 📝 Generate docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nettee nettee merged commit 2af53b5 into main Jan 21, 2026
2 of 3 checks passed
@mrcfps mrcfps deleted the revert-1301 branch January 21, 2026 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants