Skip to content

Add *WithIndex instances #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 17, 2020
Merged

Add *WithIndex instances #12

merged 7 commits into from
Jan 17, 2020

Conversation

JBetz
Copy link
Contributor

@JBetz JBetz commented Jan 16, 2020

These were added in reflex for reflex-frp/reflex#371, need to relocate them here.

@JBetz JBetz force-pushed the add-WithIndex-instances branch from d8c07ab to 33b45fe Compare January 16, 2020 23:08
@Ericson2314 Ericson2314 force-pushed the add-WithIndex-instances branch from 684d85d to c6216d3 Compare January 17, 2020 19:46
xplat
xplat approved these changes Jan 17, 2020
View reviewed changes
Copy link
Contributor

@xplat xplat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Might want to do the indexed traversals as _Wrapped .> itraverse <. traverse or so but the difference is not huge.

@Ericson2314 Ericson2314 merged commit da266c5 into develop Jan 17, 2020
@Ericson2314
Copy link
Member

@xplat

I can do itraversed = _Wrapped .> itraversed <. traversed, but then I still need to write itraverse = ... itraversed ... and I don't know how to do that.

@Ericson2314
Copy link
Member

itraverse = itraversed . Indexed nevermind!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@xplat xplat xplat approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JBetz @Ericson2314 @xplat