double down on bun over fnm/npm #4906
Merged
+174
−449
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CodSpeed Performance ReportMerging #4906 will improve performances by 17.29%Comparing Summary
Benchmarks breakdown
|
Member
Author
|
reflex-web is failing because of oven-sh/bun#17014 |
masenf
reviewed
Mar 14, 2025
Collaborator
masenf
left a comment
masenf
left a comment
There was a problem hiding this comment.
my system had an old version of node, that got picked up by bun run. we should use bun run --bun to make sure it uses bun runtime
Member
Author
|
the issue with not using node is that reflex web would fail to compile :/ |
Member
Is this just because of spline? |
Member
Author
It is because of bun failing to compile an app with spline. |
masenf
approved these changes
Mar 17, 2025
bhatia2akshit
pushed a commit
to bhatia2akshit/reflex
that referenced
this pull request
Mar 19, 2025
* double down on bun over fnm/npm * only install bun if we need a more recent version * add a better guard to for columnheader * upgrade bun * remove --bun maybe? * maybe wsl is better now * always using system node * remove installing node * rename get npm registry * check if nodejs is outdated --------- Co-authored-by: Masen Furer <m_github@0x26.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
makes initial setup faster (hopefully)