Show file and line number in deprecation warnings #4631
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adhami3310
previously approved these changes
Jan 13, 2025
adhami3310
reviewed
Jan 13, 2025
reflex/utils/console.py
Outdated
| frame = inspect.currentframe() | ||
| while frame := frame and frame.f_back: | ||
| frame_path = Path(inspect.getfile(frame)).resolve() | ||
| if frame_path.name == "typing_extensions.py": |
There was a problem hiding this comment.
is there anything special about typing_extensions? can we make that behavior generic over such examples?
There was a problem hiding this comment.
latest diff uses a more generic and extensible method for excluding packages
Less bespoke method of considering some packages to be part of the framework and passed over when finding user code.
adhami3310
approved these changes
Jan 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make it easier to track down where the deprecation warnings are coming from.