Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a sticky Built with Reflex badge #4584

Merged
merged 21 commits into from
Feb 3, 2025
Merged

Add a sticky Built with Reflex badge #4584

merged 21 commits into from
Feb 3, 2025

Conversation

Lendemor
Copy link
Collaborator

@Lendemor Lendemor commented Jan 2, 2025

To remove the badge, set SHOW_BUILT_WITH_REFLEX=0 in the environment or in rxconfig.py:

import reflex as rx

config = Config(
    "my_app",
    show_built_with_reflex=False,
)

This setting will be respected on run and export for logged in accounts on team and enterprise tier

This setting will be respected on deploy for logged in accounts on pro, team, and enterprise tier.

When the setting is True and the user is not on a high enough tier, error looks like

Warning: Config option `show_built_with_reflex` is restricted. Your current 
subscription tier is `pro`. Please upgrade to ['team', 'enterprise'] to access 
this option.

If the user is not logged in at all, the error looks like:

Warning: Config option `show_built_with_reflex` is restricted. You are currently
logged out. Run `reflex login` to access this option.

Neither of these errors are fatal, the app will just revert to the default show_built_with_reflex=True

@Lendemor Lendemor marked this pull request as ready for review January 16, 2025 20:30
@masenf masenf changed the title Add a watermark badge Add a sticky Build with Reflex badge Jan 24, 2025
@masenf masenf changed the title Add a sticky Build with Reflex badge Add a sticky Built with Reflex badge Jan 24, 2025
@PasqualePuzio
Copy link

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

Only show experimental feature warnings when accessing the names through the
rx._x namespace.

If reflex internally imports the names via deep imports, then this bypasses the
warning to avoid showing it to users that have no control over how the
framework uses experimental features.
Copy link

codspeed-hq bot commented Jan 31, 2025

CodSpeed Performance Report

Merging #4584 will not alter performance

Comparing lendemor/add_sticky_logo (ca18b1c) with main (d6e08e9)

Summary

✅ 1 untouched benchmarks

tgberkeley
tgberkeley previously approved these changes Jan 31, 2025
@masenf masenf merged commit ef93161 into main Feb 3, 2025
39 checks passed
@masenf masenf deleted the lendemor/add_sticky_logo branch February 3, 2025 19:50
masenf added a commit that referenced this pull request Feb 3, 2025
@benedikt-bartscher
Copy link
Contributor

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

It is displayed and can't be hidden on main.

@Lendemor
Copy link
Collaborator Author

Lendemor commented Feb 4, 2025

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

The settings to hide it is show_built_with_reflex :

This setting will be respected on run and export for logged in accounts on team and enterprise tier

The alternative is to manually remove the badge from the exported files.

@PasqualePuzio
Copy link

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

The settings to hide it is show_built_with_reflex :

This setting will be respected on run and export for logged in accounts on team and enterprise tier

The alternative is to manually remove the badge from the exported files.

Imho, it would have been more reasonable to remove it for self-hosted deployments, it makes much more sense for hosted apps.

@Jack-Trent
Copy link

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

The settings to hide it is show_built_with_reflex :

This setting will be respected on run and export for logged in accounts on team and enterprise tier

The alternative is to manually remove the badge from the exported files.

Imho, it would have been more reasonable to remove it for self-hosted deployments, it makes much more sense for hosted apps.

This is what I thought too. Since you're otherwise paying for resources you won't be using in order to just remove this badge. Much more cost effective to create a command to annihilate it from the build after running reflex export.

@PasqualePuzio
Copy link

@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden?

The settings to hide it is show_built_with_reflex :

This setting will be respected on run and export for logged in accounts on team and enterprise tier

The alternative is to manually remove the badge from the exported files.

Imho, it would have been more reasonable to remove it for self-hosted deployments, it makes much more sense for hosted apps.

This is what I thought too. Since you're otherwise paying for resources you won't be using in order to just remove this badge. Much more cost effective to create a command to annihilate it from the build after running reflex export.

Exactly. There are a bunch of ways to hide the badge on self-hosted deployments, I don’t see the point of trying to enforce it.

@Alek99
Copy link
Member

Alek99 commented Feb 5, 2025

We are keeping it on self hosted deployments for now. If anymore updates/changes on this topic come we will update the docs and announce via Discord and GitHub.

https://reflex.dev/docs/hosting/self-hosting/#remove-reflex-branding-from-your-self-hosted-app

@reflex-dev reflex-dev locked and limited conversation to collaborators Feb 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rate limit · GitHub

Access has been restricted

You have triggered a rate limit.

Please wait a few minutes before you try again;
in some cases this may take up to an hour.

7 participants