-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a sticky Built with Reflex badge #4584
Conversation
This config option is available for authenticated users on various plan tiers
Add role="img" aria_label="Reflex" and title="Reflex".
This reverts commit a978684.
@Lendemor how is this option handled in self-hosted mode? Is the badge displayed? If so, can it be hidden? |
Only show experimental feature warnings when accessing the names through the rx._x namespace. If reflex internally imports the names via deep imports, then this bypasses the warning to avoid showing it to users that have no control over how the framework uses experimental features.
CodSpeed Performance ReportMerging #4584 will not alter performanceComparing Summary
|
It is displayed and can't be hidden on main. |
The settings to hide it is
The alternative is to manually remove the badge from the exported files. |
Imho, it would have been more reasonable to remove it for self-hosted deployments, it makes much more sense for hosted apps. |
This is what I thought too. Since you're otherwise paying for resources you won't be using in order to just remove this badge. Much more cost effective to create a command to annihilate it from the build after running reflex export. |
Exactly. There are a bunch of ways to hide the badge on self-hosted deployments, I don’t see the point of trying to enforce it. |
We are keeping it on self hosted deployments for now. If anymore updates/changes on this topic come we will update the docs and announce via Discord and GitHub. https://reflex.dev/docs/hosting/self-hosting/#remove-reflex-branding-from-your-self-hosted-app |
To remove the badge, set
SHOW_BUILT_WITH_REFLEX=0
in the environment or inrxconfig.py
:This setting will be respected on
run
andexport
for logged in accounts on team and enterprise tierThis setting will be respected on
deploy
for logged in accounts on pro, team, and enterprise tier.When the setting is
True
and the user is not on a high enough tier, error looks likeIf the user is not logged in at all, the error looks like:
Neither of these errors are fatal, the app will just revert to the default
show_built_with_reflex=True