-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace rich progress bar to tqdm progress bar #3514
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you need to poetry lock
again for the tests
Okay |
i pushed a fix for the merge conflict here... but i think there are some other issues we need to resolve here before we can take this change.
i'm hesitant to take the new dep without fully removing the old dep |
We can use the |
It appears tqdm lacks necessary features such as colored text support and interactive prompts, so I left that part of the rich lib to handle it |
Use termcolor and inquirer python 🤔 |
Okay |
The dependency review failure is with MPL-2.0 license not APL-2.0. Note, that MPL is a copyleft license, so the maintainers should consider whether this might affect stakeholders. Might not be for most, but some enterprises steer clear of anything copyleft. Here's a nice FAQ on MPL: Also, the fix is simply, just add MPL-2.0 to the allow list. |
Marked this as draft until resynced with main. |
All Submissions:
Type of change
Please delete options that are not relevant.
New Feature Submission:
Changes To Core Features:
Description
This commit replaces the Rich progress bar implementation with TQDM #3487. The following changes were made:
Replaced Rich Progress Bar:
_zip
function to use TQDM for progress bar handling.Preserved Pretty Printing with Rich:
rich.console
for pretty printing logs and outputs to maintain readability and formatting in the console.Updated Dependencies:
pyproject.toml
as a dependency.