[REF-2370] Combine library/version into ImportVar and replace _get_imports with _get_imports_list #3198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* deprecate `_get_imports` in favor of new `_get_imports_list` * `_get_all_imports` now returns an `ImportList` * Compiler uses `ImportList.collapse` to get an `ImportDict`
Allow the user to override version pins globally via Config.frontend_packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the method for specifying ImportVar to a more flat format which is easier to combine and work with the intermediate format. No need to
merge_imports, just append the newImportVarto the list.Combination occurs in the new
ImportList.collapsefunction which handles version conflict detection and combination of other metadata that doesn't influence the identity of the ImportVar, likeinstall,render, andtranspile2024-04-30: converted to draft to focus on component public API first.