Skip to content

Implement MixedExperiment in Builder tab #248

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 53 commits into
base: master
Choose a base branch
from
Draft

Implement MixedExperiment in Builder tab #248

wants to merge 53 commits into from

Conversation

@glass-ships
Copy link
Member

@glass-ships glass-ships commented Jan 21, 2025 •
edited
Loading

Addresses #224

Implements MixedExperiment support in the Builder tab.

TODO:

  • Add UI element to assign ratio between stacks
  • Fix layer values are linked between samples due to how getSlot() works
  • Fix "Add Stack" and "Delete Stack" not working
  • Make samples draggable?
  • Add an "Add Sample" button above top-most sample?
  • Implement sortedSamples as Stack[] instead of Slab[][] in order to support Repeat layers
    • (future feature in a separate PR?)

glass-ships and others added 30 commits November 14, 2024 15:08
Formatting changes, update imports, other minor changes
8a43ba0
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
88fe2fe 
for more information, see https://pre-commit.ci
fix tests
1d6fda0
initial commit
76b7abb
fix not drawing
22a0dc2
Add label for plot mode selection
fd35c6a
add github action to test frontend
9c77d26
downgrade eslint until a fix is released
8e76ffd
add pre-commit hook for linting frontend
f11b693
fix makefile?
3a3415a
pre-commit ci doesn't seem to like using make target
62b0f71
pre-commit ci will take more effort. github action will suffice for now
8306d17
Add type testing for frontend
ac9fa53
fix modelview type errors
3c4b193
fix modelview type errors
cf205cd
fix some DataView possibly undefineds
60a8e15
merge main
2acc407
docstring for dataview interp
d2f201f
need matplotlib for testing
96d9713
TODO: Stack docstring is incomplete
39c00d2
cleanup prettier config, add lint check for backend
8379244
Merge remote-tracking branch 'origin/master' into test-types
e05f68a
merge master after bumps update
9f05264
only one issue left (in refl1d, bumps still has plenty)
2a6730c
Pin typescript to 5.6.3 until vue-tsc fix releases
ce14b4e
add svg-loader
cfd0ade
update imports, ModelData now extends Plotly.PlotData
05ad9d1
interface modeldata extends plotly plot data
514dec8
modeldata is a type again
994abf8
manual merge of master after restructure
6d51de2
bmaranville and others added 23 commits December 6, 2024 15:53
@bmaranville
install bumps-webview-client before running test:types
6f04076
merge master, reference bumps mpld3 type
4bb41d2
remove sourcemap from build script
f6f9367
update bumps to 1.0.0a11
da82ad0
test bumps@fix-libraries-package-lookup
e882fa8
merge master to resolve conflict and let actions run
4284353
Ok, bumps should be at a12 when it releases
66f129d
empty commit to re-trigger pipeline
200e95c
Merge branch 'master' into test-types
03d9fd5
update some deps
240ce35
update ruff precommit version
6ffffff
Merge branch 'master' into test-types
e30bb4e
fix reference in simple builder
c948ae4
Implement MixedExperiment in Builder tab
4f9a4f7
Add deleteStack button
b230449
merge master
a793966
fix doubly defined createModel()
a0bf562
remove fitproblem, remove panel def
bdb5a10
update eslint config
190409f
some models fail if a layer is missing material property
ef55542
add check for incompatible models
7713528
let badModel = false at first
0cba54f
Merge branch 'master' into mixed-experiment-builder
4b17823
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@glass-ships @bmaranville