[Ready for Code Review] Q&A 3.0.0 #103
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
July 9, 2015 14:53
bricesanchez
changed the title
| class: "cancel confirm-delete", | ||
| data: {confirm: t('message', scope: 'refinery.admin.delete', title: gallery.title)} | ||
| } | ||
| %> |
There was a problem hiding this comment.
the indentation here seems dubious
| delete_url = refinery.portfolio_admin_item_path(item) | ||
| delete_options = { | ||
| class: "cancel confirm-delete", | ||
| data: {confirm: t('message', scope: 'refinery.admin.delete', title: item.title)} |
bricesanchez
force-pushed
the
qa-3-0-0
branch
2 times, most recently
from
6887cf3
to
8068997
Compare
|
Is someone could review and merge this PR ? |
|
@bricesanchez could you revert the indentation back to what it was? i.e.: protected
def some_method
end
private
def another_method
endInstead of: protected
def some_method
end
private
def another_method
end |
|
It's ready @parndt :) |
parndt
added a commit
that referenced
this pull request
Aug 13, 2015
[Ready for Code Review] Q&A 3.0.0
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could you do a code review and merge it if it's good?