fix: add namespaces for useTranslate, useTranlation and useDocumentTi…#7214
Open
indramal wants to merge 1 commit intorefinedev:mainfrom
Open
fix: add namespaces for useTranslate, useTranlation and useDocumentTi…#7214indramal wants to merge 1 commit intorefinedev:mainfrom
indramal wants to merge 1 commit intorefinedev:mainfrom
Conversation
🦋 Changeset detectedLatest commit: f48654c The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicanerdurmaz
requested changes
Jan 19, 2026
Member
alicanerdurmaz
left a comment
alicanerdurmaz
left a comment
There was a problem hiding this comment.
we are not using package-lock.json, we have pnpm
| */ | ||
| export const useTranslation = () => { | ||
| const translate = useTranslate(); | ||
| export const useTranslation = (ns?: string) => { |
Member
There was a problem hiding this comment.
object would be better.
Suggested change
| export const useTranslation = (ns?: string) => { | |
| export const useTranslation = (props: { ns?: string }) => { |
| */ | ||
| export const useTranslate = () => { | ||
| export const useTranslate = ({ | ||
| ns, |
Member
There was a problem hiding this comment.
we need tests for ns support
| } | ||
|
|
||
| if (ns) { | ||
| finalOptions = { ns, ...finalOptions }; |
Member
There was a problem hiding this comment.
finalOptions can be string here. It can cause problems
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tle hooks
PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behavior?
What is the new behavior?
fixes (issue)
Notes for reviewers
Add these features as fixes
[FEAT] Add fallback and namespace for useDocumentTitle - #7198
[FEAT] Loading namespaces with useTranslation and useTranslate hooks. - #7195