Conversation
🦋 Changeset detectedLatest commit: f2152ee The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
alicanerdurmaz
left a comment
There was a problem hiding this comment.
Some example tests are failing. Could you please look into this?
You can check this document to see how to run the tests:
https://refine.dev/core/docs/guides-concepts/contributing/#running-tests
yes, will fix them as soon as I can |
|
Hello @mistervaibhav, The PR looks great 🙌 However, there are still some CI errors. When you have time, once you fix the remaining issues, we’ll start the review. Thanks a lot for contributing to Refine 🚀 |
|
Hi @mistervaibhav! I'm also eager to see the antd v6 upgrade merged soon, so I took the liberty of investigating the CI failure and found a fix. The fix is in - onClose: (e: React.MouseEvent | React.KeyboardEvent) => {
+ onClose: (
+ e: Parameters<NonNullable<DrawerProps["onClose"]>>[0],
+ ) => {The This should fix all the "Build All Examples" CI failures. Hope this helps! |
This reverts commit 23637a5.
|
Sure @Gzbox, checking this out |
|
Thanks to the bosses |
|
Thanks alicanerdurmaz for looking into this PR. I was able to run all tests successfully using
Thanks Gzbox — your suggestions helped too, along with a few other changes. |
|
Thank you very much for your effort. The PR looks quite good, but with our tight schedule, it’s very difficult to review while there are CI errors. The error itself is actually very clear; there seems to be an issue with the lock file. |
|
Thank you @mistervaibhav - do you think @ant-design/icons should be updated to v6? and @ant-design/pro-layout should use layout from @ant-design/pro-components package? |

PR Checklist
Please check if your PR fulfills the following requirements:
Bugs / Features
What is the current behaviour?
Latest Antd is not supported
What is the new behaviour?
Antd is updated internally to the latest version
fixes (#7140)
Notes for reviewers