Include more reservedPaths. Fixes #1 #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh LOL |
index.js
Outdated
| 'organizations', | ||
| 'notifications', | ||
| ]; | ||
| const reservedPaths = require('github-reserved-names').all; |
There was a problem hiding this comment.
require should be at the top to make it easier to switch to import in the future.
|
Looking good! Do you mind requiring the JSON directly? It saves a require trip |
Do you mean like this? const reservedPaths = require("./node_modules/github-reserved-names/reserved-names.json"); |
|
|
|
LOL cool... so many ways to do the same thing ;) |
This reverts commit 086aaa7.
|
LOL just as you merge, I found another reserved name... I'll publish it in a minute. |
|
If it matches |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I ran
npm testand found these messages which I did not tackle in this PR: