Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add download folder button #951

Merged
merged 4 commits into from
Jan 17, 2018
Merged

Add download folder button #951

merged 4 commits into from
Jan 17, 2018

Conversation

fregante
Copy link
Member

@fregante fregante commented Jan 5, 2018

Closes #815

It will look like this:

screenshot

The download page itself can be discussed and improved on the downloader tool's repo

@sindresorhus
Copy link
Member

sindresorhus commented Jan 17, 2018

Would be nice if we had a token field in our options, so we could just use it for this too, but that's for another PR.

@fregante
Copy link
Member Author

Yeah once we get that in our settings I can update the tool to accept the token via URL parameters, if that doesn't sound too much of a risk.

@sindresorhus
Copy link
Member

sindresorhus commented Jan 17, 2018

Yes, no more risk than trusting us with the token in this extension. I would move the download-directory.github.io repo to your account, though, so it's immediately clear who they're trusting (a maintainer of this extension).

Copy link
Member

@sindresorhus sindresorhus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit: when readme change is done.

@sindresorhus
Copy link
Member

This is really cool, by the way. I've often needed this.

@fregante
Copy link
Member Author

I would move the download-directory.github.io repo to your account

I can't. That nice URL is only available to the download-directory org. It initially was bfred-it.github.io/github-download-dir, then github-download-dir.bfred.it, then that.

I can add my © Name in the tool itself but it's not like anyone knows me anyway.

@fregante
Copy link
Member Author

Readme screenshot

screen shot 2018-01-17 at 20 11 59

@fregante fregante merged commit 2335a3f into master Jan 17, 2018
@sindresorhus sindresorhus deleted the add-download-folder-button branch January 17, 2018 13:17
@sindresorhus
Copy link
Member

sindresorhus commented Jan 17, 2018

Ah ok, maybe add that that URL is trusted by Refined GitHub, so people are immediately aware how they ended up on a different URL.

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

source/features/add-download-folder-button.js

@refined-github refined-github deleted a comment Oct 23, 2019
@johanohly
Copy link

I could just be doing something wrong but I can't see the download button in a folder. The readme screenshots show an older UI. The button row is gone in the new github design I think?

@stamminator
Copy link

Reporting the same as @JohnnyJTH. No more download button.

@cheap-glitch
Copy link
Contributor

I have one on Firefox with RGH v22.1.18. It's in the little dropdown on the far left:

image

@stamminator
Copy link

@JohnnyJTH @cheap-glitch Looks like the issue is taking place if it's not the default branch #5335 (comment)

@Eversor
Copy link

Eversor commented Jan 26, 2023

Confirm not working anymore on chrome. The folder i'm trying to download seem to be the main branch afaik.
This is the folder in question: https://github.com/MonoGame/MonoGame.Dependencies/tree/master/MojoShader
Extension version : v22.12.15

@refined-github refined-github locked and limited conversation to collaborators Jan 26, 2023
@fregante
Copy link
Member Author

fregante commented Jan 26, 2023

Please don't leave comments on 5-year-old issues. Open a new bug report instead or search for open ones:

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Development

Successfully merging this pull request may close these issues.

Download specific folder?
7 participants