-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Test URL check to Vitest #7694
Conversation
fregante
commented
Aug 17, 2024
•
edited
Loading
edited
- Completes Improve feature verification #7132 (comment)
- Blocked by 🏓 Help add test URLs to the last features #7656
LAST_LINE=$(wc -l < "$FILE") | ||
if grep -q "test url" -i "$FILE"; then | ||
echo ✅ "$FILE" | ||
echo "::notice file=$FILE,line=$LAST_LINE::✅" >> "$ANNOTATIONS" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be nice to still output this positive annotation on all files though, just to bring the test URLs to light when reviewing, but it seems it's already not working?
|
||
The section must be appended to each .tsx file: | ||
|
||
/* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I need to restore this message too, to help user document new features. The message needs to be updated.
Current output, waiting for:
|