Use pull request title for squash and merge commit message #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hkdobrev
force-pushed
the
squash-merge-title
branch
from
9a55c76 to
d2e65f0
Compare
|
@sindresorhus What do you think about this? |
extension/content.js
Outdated
| @@ -377,6 +377,12 @@ function removeProjectsTab() { | |||
| } | |||
| } | |||
|
|
|||
| function fixSquashAndMergeTitle() { | |||
| $('.btn-group-squash button[type=submit]').click(() => { | |||
| $('#merge_title_field').val($('.js-issue-title').text().trim() + ' (' + $('.gh-header-number').text() + ')'); | |||
There was a problem hiding this comment.
Any reason you chose not to use a template literal here?
$('#merge_title_field').val(`${$('.js-issue-title').text().trim()} (${$('.gh-header-number').text()})`);
There was a problem hiding this comment.
Just the habit of too much writing on ES5. Will change that tomorrow.
|
Can you add it to the feature highlight? No screenshot needed. |
sindresorhus
changed the title
hkdobrev
force-pushed
the
squash-merge-title
branch
from
d2e65f0 to
350f753
Compare
|
@sindresorhus @paulmolluzzo Updated. |
|
Great! This is going to be sooo useful for me. I do this manually many times every day. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #276