Make releases-tab non dependent of more-dropdown
#3654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The dropdown is native, we’re not creating it. Perhaps the only problem is that there’s no native separator in there. |
fregante
reviewed
Oct 15, 2020
fregante
reviewed
Oct 19, 2020
source/features/releases-tab.tsx
Outdated
| 'data-menu-item': 'rgh-releases-item' | ||
| }) | ||
| ); | ||
| const moreDropdown = select('.dropdown-divider', repoNavigationBar); |
There was a problem hiding this comment.
Actually we should just match the logic on line 85, which simply appends it. We only need to slightly modify because we have a divider.
Thankfully we have an helper function that does this exactly. I think the only change needed is:
Suggested change
| const moreDropdown = select('.dropdown-divider', repoNavigationBar); | |
| appendBefore( | |
| select('.js-responsive-underlinenav .dropdown-menu ul'), | |
| '.dropdown-divider', // Won't exist if `more-dropdown` is disabled | |
| createDropdownItem('Releases', `/${repoUrl}/releases`, { | |
| 'data-menu-item': 'rgh-releases-item' | |
| }) | |
| ); |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
…led" This reverts commit d9e74ae.
Co-Authored-By: Fregante <opensource@bfred.it>
|
PR title needs update then it’s ok if it works |
yakov116
changed the title
release-tab to the more-dropdown if its enabledrelease-tab non dependent of more-dropdown
|
How is it now? |
yakov116
changed the title
release-tab non dependent of more-dropdownreleases-tab non dependent of more-dropdown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LINKED ISSUES:
Resolves
Release-tabthrows an error ifmore-dropdownis turned off #3652TEST URLS:
None
SCREENSHOT:
None