Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor dashboard features to use selector-observer #3521

Merged
merged 21 commits into from
Sep 25, 2020
Merged

Refactor dashboard features to use selector-observer #3521

merged 21 commits into from
Sep 25, 2020

Conversation

yakov116
Copy link
Member

  1. LINKED ISSUES:
    Fixes open-issue-to-latest-comment doesn't work consistently #3469

  2. TEST URLS:
    https://github.com/

  3. SCREENSHOT:
    There should be no changes

@fregante
Copy link
Member

Can you also remove “default listeners” the line from features/index?

Are there any other features with isDashboard?

@yakov116
Copy link
Member Author

Only infinite-scroll but that is too complex for me to try and change,

@fregante fregante changed the title Use select-observer for features run on the dashboard Use selector-observer for features run on the dashboard Aug 30, 2020
@fregante
Copy link
Member

Only infinite-scroll but that is too complex for me to try and change,

That's fine as is, it only need the explicit onNewsfeedLoad now after 00f78fe

@fregante fregante changed the title Use selector-observer for features run on the dashboard Refactor dashboard features to use selector-observer Aug 30, 2020
@fregante fregante added the meta Related to Refined GitHub itself label Aug 30, 2020
@fregante
Copy link
Member

Likewise, the same can be done for any every/most hasComments feature in a future PR. (initially mentioned in #3407 (review))

@fregante fregante added the bug label Aug 31, 2020
@yakov116
Copy link
Member Author

@fregante I had an emergency come up I may be off for a day or 2. I will try to finish it soon.

@yakov116
Copy link
Member Author

yakov116 commented Sep 1, 2020

Done

@yakov116
Copy link
Member Author

yakov116 commented Sep 2, 2020

What about show-names?

@fregante fregante closed this Sep 9, 2020
@fregante fregante reopened this Sep 25, 2020
@fregante
Copy link
Member

fregante commented Sep 25, 2020 •
edited
Loading

This doesn't appear to be affected by https://github.com/josh/selector-observer/issues/30 👍

You can merge it if you don't to make further changes.

@yakov116
Copy link
Member Author

yakov116 commented Sep 25, 2020 •
edited
Loading

@fregante I restored the listener for now for show-names. I will come back to it.

Are we good to merge now?

@yakov116 yakov116 merged commit 7654364 into refined-github:master Sep 25, 2020
@yakov116 yakov116 deleted the dashboardselectobserver branch September 25, 2020 02:30
kidonng pushed a commit to kidonng/refined-github that referenced this pull request Oct 7, 2020
@yakov116 @fregante @kidonng
Refactor dashboard features to use selector-observer (refined-githu…
ccebb61 
…b#3521)

Co-authored-by: Federico <me@fregante.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fregante fregante fregante approved these changes

Assignees
No one assigned
Labels
bug meta Related to Refined GitHub itself
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

open-issue-to-latest-comment doesn't work consistently
2 participants
@yakov116 @fregante