Refactor conversation-links-on-repo-list to use selector-observer

[yakov116]

1. LINKED ISSUES:
   Let's make Refined GitHub faster ⚡️ #2671

2. TEST URLS:
   https://github.com/search?q=user%3Asindresorhus+sindre
   https://github.com/sindresorhus?tab=repositories&type=source

3. SCREENSHOT:
   None

[fregante]

Looks right

[fregante]

Actually… it’s not faster. I found out that selector-observer always waits for dom-ready. This sort of limits the usefulness of this package. I wonder if we need to find another package.

It makes sense that it waits (for performance reasons) but also this means that features are no longer instant.

[yakov116]

Your right. 😢 https://github.com/josh/selector-observer/blob/master/lib/ready.js

I have however found that on Ajax requests or when we were doing observelement on init this was faster. But otherwise it only makes it simpler.

[fregante]

👎 This doesn't seem to have benefits, according to #3084 (comment) — that is, this is not a "ajaxed hot-area"

Thoughts?

[fregante]

I guess this does have observeElement('#user-repositories-list', init) and the initialization is slightly shorter. It could be ok

[fregante]

Congrats on your first merged PR 😸

[yakov116]

Thanks!

[jerone]

Duplicate page detect :)

[fregante]

I feel a Lint PR coming

[yakov116]

@fregante I am going to send a lint pr but I only have 2 small things. Have any lint in mind??

[fregante]

Can you cleanup some feature names?

• cleanup -> clean
• rename add-tags-to-commits to tags-on-commits-list

Also if you want to:

• Ensure descriptions always end with . and use the 3rd person (in source or readme). grep/ripgrep or your editor’s search can help
• Change all cache durations to be on one line, i.e. maxAge: {hours: 1}
• Double-check if TODOs have been resolved or can easily be resolved
• Verify whether some screenshots: false features could have a screenshot
• Check whether features still work, picking some at random or in any order you'd like

Not quite lint, but:

• See if you want to do any of the good first issues, particularly bugs

lint-ideas

[yakov116]

• Change all cache durations to be on one line, i.e. maxAge: {hours: 1}

Haha I made them on new lines since I though it was easier to read