Update personal token link based off domain selected #2478
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fregante
requested changes
Oct 9, 2019
fregante
reviewed
Oct 9, 2019
busches
force-pushed
the
custom-settings-link
branch
from
0f52b07 to
b2f20c8
Compare
fregante
reviewed
Oct 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the
personal tokenlink in the settings to use the domain from the dropdown to construct the link. When there is no link, it defaults to GitHub. We now show the protocol in the domain dropdown, otherwise I had to infer it for the link.Closes #2408
Test
I tested it on GH, a random site I gave permission to, and then a GHE instance (2.17) to confirm the settings URL was the same as GH, it is.