Temporary fix for widen-search-field
#2436
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KubaJastrz
changed the title
widen-search-field
|
The Either it’s tested and not temporary or we can’t risk merging this and breaking another part 😅 |
|
Makes sense, in that case it would be best to disable this feature for the time being. |
fregante
approved these changes
Sep 14, 2019
|
Needs further testing, but this fixes the height. It can be merged before the next release (in 13 hours) unless bugs are found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Technically fixes #2435
GitHub made some weird changes to their css regarding
.subnavselector on Issues and Pull Requests pages. It looks like they are migrating from the old.float-left/rightmodel to flexbox, but at the same time they ignore existing "semantic" classes.You can also see it on the Releases page where they are using the old
.subnavand.d-flex.flex-justify-between.I would call this PR a temporary workaround until things settle down with GitHub changes. Also, we should probably expect some more broken features soon.
Test
Open issues or pull request page and see.