Restore lock icons on private orgs

[doms]

What

Fixes #2210

Notes

After some digging, it seems as though the response from GitHub's API changed a bit(?), and some of the keys in the response aren't iterable. 🤔

This just uses an explicit Object.values around the publicOrgs response object. 😄

Before

After

[fregante]

They should be iterable; if this happens there must be a problem in the API or in the cache module. Can you show me exactly what publicOrgs looks like at first?

It seems to work for me in Chrome and Firefox

[doms]

Perhaps “not iterable” was a poor choice of words, but I wasn’t sure other words to use to describe it when I was debugging.

When I was console.log’ing the response of fetching the public orgs, the response would look like as shown:

And so I figured I would iterate through the keys, and it seemed that sometimes I was getting 0 as a key, so I figured that’s why it was error’ing out with the publicOrgs.map is not a function 🤔

let publicOrgs = await api.v3(`users/${getUsername()}/orgs`);
	
// console.log's to see the contents of `publicOrgs` response
console.log(publicOrgs)	
for (let key in publicOrgs) {
	console.log('key: ', key)
}
	
publicOrgs = Object.values(publicOrgs).map((orgData: AnyObject) => `/${orgData.login}`);

As you see in the screenshot, we are getting the keys of:

• 0 (the actual response as shown in the first image above)
• status
• ok

It seems that status: 200 and ok: true are key-value pairs, and the 0 key has the user orgs as the values 🤔

So I figured I would just use Object.values(publicOrgs) to make sure I was getting a type that did have the map functionality (Array), and go from there. It seems to have solved the issue, but the weird part is that the original code works too in a different environment (https://repl.it/repls/DefiantCraftyInterface)

I'm getting similar behavior in both Brave (Chromium) and Firefox.

So yea, not entirely sure what’s happening, but I figured I would attempt to fix it maybe get some feedback in the code review on why mark-private-orgs might be broken on my end. 😄

[jerone]

I can confirm this issue:

It is because the API itself returns an array, which is because of recent change now spread to an object in #2185. Resulting in using the map function on an object instead of the previous array.

[fregante]

@jerone that’s funny 😅 good catch

The solution is to use return Object.assign(array, {.......})