Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add list-prs-for-file feature #2197

Merged
merged 24 commits into from
Jul 14, 2019

Conversation

jerone
Copy link
Contributor

@jerone jerone commented Jun 30, 2019

Description

Highlight affected PRs in file.

Closes

Closes #1323

Test

TODO

  • Caching.
  • Improve name. Suggestions...
  • Consider getting PR's from original when in own fork?

IssueHunt Summary

Referenced issues

This pull request has been submitted to:


IssueHunt has been backed by the following sponsors. Become a sponsor

@jerone jerone force-pushed the highlight-file-in-prs branch from 9a35ebf to b6e17f8 Compare July 1, 2019 19:06
@jerone jerone force-pushed the highlight-file-in-prs branch from b6e17f8 to 3becb96 Compare July 1, 2019 19:55
jerone and others added 8 commits July 3, 2019 09:17
Co-Authored-By: Federico Brigante <github@bfred.it>
Co-Authored-By: Federico Brigante <github@bfred.it>
@jerone jerone force-pushed the highlight-file-in-prs branch from b4badaf to 1ba5498 Compare July 5, 2019 18:49
@jerone jerone changed the title Add highlight-file-in-prs feature Add highlight-affected-prs-in-file feature Jul 5, 2019
@jerone jerone marked this pull request as ready for review July 5, 2019 19:03
@jerone
Copy link
Contributor Author

jerone commented Jul 5, 2019

@bfred-it & @sindresorhus This is ready for testing and review 🐱‍👤

@fregante

This comment has been minimized.

@jerone

This comment has been minimized.

@fregante

This comment has been minimized.

@jerone

This comment has been minimized.

@fregante

This comment has been minimized.

# Conflicts:
#	source/content.ts
# Conflicts:
#	source/content.ts
@fregante fregante changed the title Add highlight-affected-prs-in-file feature Add list-prs-for-file feature Jul 14, 2019
PRs are not affected, *files* are affected

PRs are not highlighted (since they don't appear anywhere in the page, we're *adding* them, not *highlighting* them)
@fregante fregante self-assigned this Jul 14, 2019
@fregante
Copy link
Member

fregante commented Jul 14, 2019

I made them more prominent on Edit pages:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

List opened PRs touching displayed file
3 participants