Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix left-join for multiple matches #402

Merged
merged 1 commit into from
Nov 9, 2024
Merged

Conversation

rokostik
Copy link
Contributor

@rokostik rokostik commented Nov 9, 2024

This PR fixes the left-join and inner-join functions to behave the same as when using a SQL database (ie. returning all the matches and not just the first one).

Closes #319

Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, I plan to write a cookboook about Spreadsheets and it's nice to have this unified with SQL.

@refaktor refaktor merged commit deadd8d into refaktor:main Nov 9, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: left-join should return all matching combinations of rows
2 participants