Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Adding math function] Support for Dim, Copysign functions #211

Merged
merged 3 commits into from
May 14, 2024
Merged

[Adding math function] Support for Dim, Copysign functions #211

merged 3 commits into from
May 14, 2024

Conversation

pratikmota
Copy link
Contributor

Changes:

  1. Adding support for Copysign and Dim math function
  2. Adding test cases

Testing:
image

image

Test cases:
image

@pratikmota pratikmota marked this pull request as ready for review May 12, 2024 11:23
refaktor
refaktor approved these changes May 14, 2024
View reviewed changes
Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you Pratik for the PR!

@refaktor refaktor merged commit 527dfea into refaktor:main May 14, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@refaktor refaktor refaktor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pratikmota @refaktor