Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Adding math function] Support for Asin, Asinh, Atan #188

Merged
merged 2 commits into from
Apr 8, 2024

Conversation

pratikmota
Copy link
Contributor

@pratikmota pratikmota commented Apr 7, 2024

Changes:

  1. Adding support for Asin, Asinh, and Atan math functions
  2. Adding test cases for Asin, Asinh and Atan math functions

Testing:
commands:
image

image

image

test cases:
I have already written test cases. There are some issue due to last checkins. Did you modified anything related basics?
Right now i am getting below errors. It is not related to my code changes. So we can merge given PR.
image
If i comment 418 line number and run then giving error at a different line. so not able to understand exact issue.

@pratikmota pratikmota marked this pull request as ready for review April 7, 2024 14:23
Copy link
Owner

@refaktor refaktor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR! And thanks for nice error messages and tests!

@refaktor refaktor merged commit 66bdf72 into refaktor:main Apr 8, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants