Skip to content

Conversation

@mustafa-guler
Copy link

Similar to serde support this adds optional support for the rkyv (de)serialization framework for OrderedFloat and NotNan. It is feature-gated the same way serde is.

Implementations are based on the trait implementations for primitives from the rkyv crate instead of derive macros to avoid the intermediate ArchivedX type that doesn't implement the comparison traits.

Similar to serde support this adds support for the `rkyv`
(de)serialization framework for `OrderedFloat` and `NotNan`. It is
feature-gated the same way serde is.
@mustafa-guler
Copy link
Author

mustafa-guler commented Sep 2, 2021

test failures appear to be related to this proptest issue. Could 1.36.0 be too small of a MSRV to support proptest 1.0?

@mbrubeck
Copy link
Collaborator

mbrubeck commented Sep 2, 2021

test failures appear to be related to this proptest issue. Could 1.36.0 be too small of a MSRV to support proptest 1.0?

Good catch. Fixed in #97.

Thanks for the PR!

@mbrubeck mbrubeck merged commit 9823d42 into reem:master Sep 2, 2021
@mbrubeck
Copy link
Collaborator

mbrubeck commented Sep 2, 2021

Published: https://crates.io/crates/ordered-float/2.8.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants