Skip to content

Conversation

@lemmih
Copy link
Contributor

@lemmih lemmih commented Jul 5, 2021

proptest doesn't support no_std on stable. Will this cause trouble or is it fine as long as the dependency is optional?

@lemmih
Copy link
Contributor Author

lemmih commented Jul 6, 2021

Hm, it might make more sense for proptest to have an optional dependency on ordered-float rather than the other way around.
I'll withdraw the PR.

@lemmih lemmih closed this Jul 6, 2021
@mbrubeck
Copy link
Collaborator

mbrubeck commented Jul 6, 2021

Hm, it might make more sense for proptest to have an optional dependency on ordered-float rather than the other way around.

I think either way would be okay. Feel free to re-open this PR depending on what the proptest developers say.

proptest doesn't support no_std on stable. Will this cause trouble or is it fine as long as the dependency is optional?

That's fine.

@lemmih lemmih reopened this Jul 12, 2021
@lemmih
Copy link
Contributor Author

lemmih commented Jul 12, 2021

I think either way would be okay. Feel free to re-open this PR depending on what the proptest developers say.

They said the impl would be better in this crate. I've re-opened the PR.

@mbrubeck mbrubeck merged commit a0d432a into reem:master Jul 12, 2021
@mbrubeck
Copy link
Collaborator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants