Various small updates #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks great, thanks! There are still a few type errors in some of the |
|
Yeah, I saw those. I know the causes (generic vs non generic conflict), I
just need to go through and fix.
Also, I'd appreciate if someone could confirm for me that it's not possible
for negation to ever produce NaN.
|
|
Tests are passing, but I'm actually not sure if the refactored code is tested, might want to check that before merging |
- Deduplicated implementations of `AddAssign`, `SubAssign`, etc
- Replaced `Into` implementations with equivelent `From` implementations
- Refactored most operators in terms of the "plain" versions:
-`Add<Self> for NotNan<T>` is now based on `Add<T> for NotNan<T>`, etc.
- More efficient implementation of `Ord` for `NotNan`
- Removed many unnecessary asserts for `self.0.is_nan()`
- Fixes reem#54
|
Confirmed that the relevant tests do already exist |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Various small code updates & refactors, focused on removing redundant asserts and deduplication.
Fixes #54