Prefer Nan to NaN
#28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lo48576
force-pushed
the
nan-naming-convention
branch
from
e194501 to
8a66519
Compare
[Rust's RFC 0430 about naming conventions](https://github.com/rust-lang/rfcs/blob/master/text/0430-finalizing-naming-conventions.md#fine-points) says: > In `CamelCase`, acronyms count as one word: use `Uuid` rather than `UUID`. Standard library follows this rule and uses `Nan` (see `std::num::FpCategory::Nan`), so this crate had better use `Nan`.
lo48576
force-pushed
the
nan-naming-convention
branch
from
8a66519 to
4c52f74
Compare
|
Resolved conflicts and rebased onto master (0.5.0). |
|
I suggest you add some #[deprecated(since = "0.6.0", note = "renamed to NotNan")]
pub type NotNaN<T> = NotNan<T>;
// etc. |
added 2 commits
July 13, 2017 15:48
For compatilibity reason, old names should be available for a while.
Copied tests from master branch and added `allow(deprecated)`.
|
Restored |
|
I published a (hopefully temporary) fork that includes this change: https://crates.io/crates/new-ordered-float |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rust's RFC 0430 about naming conventions says:
Standard library follows this rule and uses
Nan(seestd::num::FpCategory::Nan), so this crate had better useNan.