Fix skew in hash computation #19
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reem
approved these changes
Jan 31, 2017
| } else { | ||
| false | ||
| } | ||
| if other.as_ref().is_nan() { true } else { false } |
There was a problem hiding this comment.
it occurs to me that this should just be other.as_ref().is_nan() the if/else is totally unnecessary
note: I know this is just an automated whitespace change but if it's convenient feel free to make the change
| impl Error for FloatIsNaN { | ||
| fn description(&self) -> &str { | ||
| return "NotNaN constructed with NaN" | ||
| return "NotNaN constructed with NaN"; |
There was a problem hiding this comment.
this could also just be the literal
|
I noticed some random stuff that could be improved, but since it's unrelated to your excellent change I'll just go ahead and merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #18 by introducing a better implementation of
Hashwhich improves the added tests such that neither has any collisions. Previously, the whole number test had~50%unique hash codes, and the fractional test had~80%unique hash codes.Also, my
auto-rustfmtkicked in on a few lines, hence the unrelated whitespace changes.