Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changelog or a clear list of breaking changes between releases? #140

Closed
pacak opened this issue Sep 24, 2023 · 1 comment · Fixed by #141
Closed

Changelog or a clear list of breaking changes between releases? #140

pacak opened this issue Sep 24, 2023 · 1 comment · Fixed by #141

Comments

@pacak
Copy link

pacak commented Sep 24, 2023

  1. I'm trying to update our codebase to the next release, code fails to compile. Usually it's a quick look at the changelog or release merge request, but neither seems to be available. Would be great to have this.

  2. Breaking change was introduced in Unconditionally bound with T: FloatCore. #138 which requires to add a new constraint. Adding constraints is not a problem, but to add it I have to add a new dependency - num-traits which must be the same version (within cargo compatible versions) as ordered-float uses. This would break as soon as num-traits releases a new major version, usual approach is to reexport such traits so constraints can look like this instead:

fn problem<T>(inputs: &mut [OrderedFloat<T>])
where
    T: ordered_float::FloatCore,
{
    inputs.sort();
}
@mbrubeck
Copy link
Collaborator

There is a changelog here: https://github.com/reem/rust-ordered-float/releases

I should add a link to the README and docs to make it more discoverable.

mbrubeck added a commit that referenced this issue Sep 24, 2023
mbrubeck added a commit to mbrubeck/rust-ordered-float that referenced this issue Sep 24, 2023
mbrubeck added a commit to mbrubeck/rust-ordered-float that referenced this issue Sep 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants