Skip to content

ci: re-enable windows test coverage #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maxlandon merged 1 commit into from
Jul 11, 2025
Merged

ci: re-enable windows test coverage #85

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/go.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,6 @@ jobs:
run: go build -v ./...
shell: powershell

# - name: Run coverage
# run: go test -v ./...
# shell: powershell
- name: Run coverage
run: go test -v ./...
shell: powershell
8 changes: 7 additions & 1 deletion inputrc/inputrc_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -186,6 +186,9 @@ func readTest(t *testing.T, name string) [][]byte {
t.Fatalf("expected no error, got: %v", err)
}

// Correct for Windows line endings, as test files are embedded.
buf = bytes.ReplaceAll(buf, []byte("\r\n"), []byte("\n"))

return bytes.Split(buf, []byte(delimiter))
}

Expand Down Expand Up @@ -391,6 +394,9 @@ func readTestdata(name string) ([]byte, error) {
return nil, err
}

// Correct for Windows line endings, as test files are embedded.
buf = bytes.ReplaceAll(buf, []byte("\r\n"), []byte("\n"))

v := bytes.Split(buf, []byte(delimiter))
if len(v) != 3 {
return nil, fmt.Errorf("test data %s is invalid", name)
Expand All @@ -400,4 +406,4 @@ func readTestdata(name string) ([]byte, error) {
}

//go:embed testdata/*.inputrc
var testdata embed.FS
var testdata embed.FS