chore(refactor): Router: Splitting things up into smaller files #9988
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dac09
added a commit
to dac09/redwood
that referenced
this pull request
Feb 12, 2024
…d-cookies-dbauth * 'main' of github.com:redwoodjs/redwood: fix(dependencies): Use RW-specific version of apollo ssr package (redwoodjs#9992) RSC: chore(test): Update RSC test fixture project (redwoodjs#9990) RSC: createServerCell (redwoodjs#9987) chore(refactor): Router: Splitting things up into smaller files (redwoodjs#9988) chore(project-config): make chore changes to trigger ci (redwoodjs#9985)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Splitting up some files in the router package into smaller pieces for finer granularity when importing things.
This gets more important with RSCs where you don't want a single client-only import in a file block the usage of all the functions/components in that file.
When putting
<Link />and<NavLink />into separate files I also took the opportunity to use a composition pattern, so that<NavLink />internally uses<Link />. To make sure I didn't break anything when doing so I updated our test project fixture to use<NavLink />s for the main blog layout, and gave them all a nice little underline to show what page you're currently on