Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RSC: Remove unused code. Improve code organization #9631

Merged
merged 4 commits into from
Dec 6, 2023
Merged

RSC: Remove unused code. Improve code organization #9631

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
30db6a2
RSC: Remove unused code, and move things around to improve code organ…
Tobbe Dec 5, 2023
3f4fc49
RSC: TODO about regex with variable
Tobbe Dec 5, 2023
1f3cd72
rscNodeLoader
Tobbe Dec 6, 2023
b488857
Merge branch 'main' into tobbe-rsc-clean-waku-lib
Tobbe Dec 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
RSC: TODO about regex with variable
  • Loading branch information
@Tobbe
Tobbe committed Dec 5, 2023
commit 3f4fc49299c0530fad373568db812186c1088b37
2 changes: 2 additions & 0 deletions packages/vite/src/rsc/rscWorker.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -385,6 +385,8 @@ async function renderRsc(input: RenderInput): Promise<PipeableStream> {
}

// HACK Patching stream is very fragile.
// TODO (RSC): Sanitize prefixToRemove to make sure it's safe to use in a
// RegExp (CodeQL is complaining on GitHub)
function transformRsfId(prefixToRemove: string) {
// Should be something like /home/runner/work/redwood/test-project-rsa
console.log('prefixToRemove', prefixToRemove)
Expand Down
Loading