Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Prevent rw graphiql setup from breaking with encryptSession error #9582

Merged
merged 4 commits into from
Nov 28, 2023
Merged

fix: Prevent rw graphiql setup from breaking with encryptSession error #9582

merged 4 commits into from
Nov 28, 2023

Conversation

staticshock
Copy link
Contributor

Fixes #9581

staticshock
staticshock commented Nov 28, 2023
View reviewed changes
.editorconfig
@@ -7,7 +7,7 @@ root = true
[*]
end_of_line = lf
insert_final_newline = true
charset = utf8
charset = utf-8
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, this is unrelated, but didn't seem worth its own PR. Let me know if y'all disagree and I'll turn it into a separate PR.

@dac09 dac09 self-assigned this Nov 28, 2023
@dac09
Copy link
Collaborator

dac09 commented Nov 28, 2023

Thanks for the PR @staticshock! Looking at it now :)

@staticshock staticshock changed the title fix: graphiql setup doesn't break on encryptSession fix: Prevent rw graphiql setup from breaking with encryptSession error Nov 28, 2023
@dac09 dac09 added the release:fix This PR is a fix label Nov 28, 2023
@dac09 dac09 added this to the next-release-patch milestone Nov 28, 2023
@dac09 dac09 added the fixture-ok Override the test project fixture check label Nov 28, 2023
@dac09
Copy link
Collaborator

dac09 commented Nov 28, 2023

Thanks @staticshock - setup working correctly, however I think we also need the same change in packages/studio/api/lib/authProviderEncoders/dbAuthEncoder.ts

Are you able to verify that the session is being impersonated in studio when you run yarn rw experimental studio?

@dac09
Copy link
Collaborator

dac09 commented Nov 28, 2023

Applied changes to studio as well, thanks @staticshock for the PR and the well written (and analysed) issue ✌️

@dac09 dac09 merged commit ff54c11 into redwoodjs:main Nov 28, 2023
32 checks passed
@staticshock staticshock deleted the fix-encryptSession branch November 28, 2023 15:28
@staticshock
Copy link
Contributor Author

Thanks for the quick merge!

jtoar pushed a commit that referenced this pull request Nov 29, 2023
@staticshock @dac09 @jtoar
fix: Prevent rw graphiql setup from breaking with encryptSession er…
673de54 
…ror (#9582)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: next-release-patch, v6.4.1 Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
@staticshock @dac09 @jtoar
fix: Prevent rw graphiql setup from breaking with encryptSession er…
5863f00 
…ror (#9582)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
@jtoar jtoar modified the milestones: v6.4.1, next-release-patch Nov 29, 2023
jtoar pushed a commit that referenced this pull request Nov 29, 2023
@staticshock @dac09 @jtoar
fix: Prevent rw graphiql setup from breaking with encryptSession er…
4b93bc2 
…ror (#9582)

Co-authored-by: Daniel Choudhury <dannychoudhury@gmail.com>
dac09 added a commit that referenced this pull request Jan 22, 2024
@dac09
Merge branch 'main' of github.com:redwoodjs/redwood into try/setupSce…
e0104f6 
…nario-multiple-tests

* 'main' of github.com:redwoodjs/redwood: (21 commits)
  fix(deps): update dependency @whatwg-node/server to v0.9.18 (#9602)
  fix(deps): update dependency @apollo/client to v3.8.8 (#9600)
  chore: update yarn.lock
  chore(deps): update dependency @playwright/test to v1.40.1 (#9599)
  chore(deps): update dependency @supabase/supabase-js to v2.39.0 (#9603)
  fix(deps): update dependency @clerk/clerk-sdk-node to v4.12.22 (#9601)
  chore(deps): update dependency @clerk/clerk-react to v4.28.1 (#9598)
  fix(deps): update storybook monorepo to v7.6.2 (#9597)
  RSC: Generate a route manifest (#9592)
  chore(private-set): Wrap profile page in <PrivateSet> instead of Private (#9575)
  add documentation on mocking useParams in component test (#9284)
  Update Typescript to 5.3.2 (#9589)
  RSC: Refactor build process (#9588)
  fix(crwa): clarify docs to avoid issues in yarn modern installs (#9579)
  fix: Prevent `rw graphiql setup` from breaking with encryptSession error (#9582)
  fix: Remove "god code" typos from auth READMEs (#9583)
  Experimental Dockerfile: Fix typo in setup command (#9577)
  fix(streaming-ssr): Fixes running the streaming server using rw serve (#9558)
  9316/update mantine setup (#9388)
  chore: clean up `RouteParams` type test structure (#9573)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dac09 dac09 dac09 approved these changes

Assignees

@dac09 dac09

Labels
fixture-ok Override the test project fixture check release:fix This PR is a fix
Projects
None yet
Milestone
v6.4.1
Development

Successfully merging this pull request may close these issues.

[Bug?]: yarn rw setup graphiql dbAuth fails on v6.4.0
3 participants
@staticshock @dac09 @jtoar