fix: handle tsconfig.tsbuildinfo in clean, sync
#9415
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Nov 13, 2023
Josh-Walker-GM
approved these changes
Nov 13, 2023
jtoar
added a commit
that referenced
this pull request
Nov 16, 2023
Follow up to #9390. Previously, framework sync would remove all of a package's dist, then rebuild it. This meant the `tsconfig.tsbuildinfo` was removed too. #9390 moved the `tsconfig.tsbuildinfo`, saving megabytes of space for user's projects, but didn't update `yarn build:clean` or `yarn rwfw project:sync`. This PR restores their behavior. Paired with @Josh-Walker-GM on this one.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #9390. Previously, framework sync would remove all of a package's dist, then rebuild it. This meant the
tsconfig.tsbuildinfowas removed too.#9390 moved the
tsconfig.tsbuildinfo, saving megabytes of space for user's projects, but didn't updateyarn build:cleanoryarn rwfw project:sync. This PR restores their behavior. Paired with @Josh-Walker-GM on this one.