fix(serverless): move project-config to auth-dbauth-api dependencies #9281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tobbe
approved these changes
Oct 8, 2023
jtoar
added a commit
that referenced
this pull request
Oct 8, 2023
…9281) After cherry picking #9248, Netlify and Vercel deploys were broken with the following error: <img width="1532" alt="image" src="https://github.com/redwoodjs/redwood/assets/32992335/2e366cd9-48e7-46e6-a32e-1c7872418674"> It took me a second to realize it, but `@redwoodjs/project-config` is listed as a dev dependency in `@redwoodjs/auth-dbauth-api` despite being used in a source file: https://github.com/redwoodjs/redwood/blob/040589a4e600e298837e3f2b7373d1c2403eb784/packages/auth-providers/dbAuth/api/src/shared.ts#L4 @Tobbe this may not be the end of it—in those environments, there's no `redwood.toml` either, so I think `getConfig` will throw. But we can solve one bug at a time.
jtoar
added a commit
that referenced
this pull request
Nov 3, 2023
Follow up to #9281. The functionality added in #9248 depends on the `redwood.toml` file. This file doesn't exist in serverless environments. A quick note on the implementation. I could've done this: ```js let config try { config = getConfig() } catch (e) { if (e.message !== `Could not find a "redwood.toml" file, are you sure you're in a Redwood project?`) { throw e } } // ... ``` But that seemed more brittle because it depends on the error message. Lastly, `getConfig` merges defaults with the raw config, so I don't think the `api?.port` is necessary.
jtoar
added a commit
that referenced
this pull request
Nov 3, 2023
Follow up to #9281. The functionality added in #9248 depends on the `redwood.toml` file. This file doesn't exist in serverless environments. A quick note on the implementation. I could've done this: ```js let config try { config = getConfig() } catch (e) { if (e.message !== `Could not find a "redwood.toml" file, are you sure you're in a Redwood project?`) { throw e } } // ... ``` But that seemed more brittle because it depends on the error message. Lastly, `getConfig` merges defaults with the raw config, so I don't think the `api?.port` is necessary.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After cherry picking #9248, Netlify and Vercel deploys were broken with the following error:
It took me a second to realize it, but
@redwoodjs/project-configis listed as a dev dependency in@redwoodjs/auth-dbauth-apidespite being used in a source file:redwood/packages/auth-providers/dbAuth/api/src/shared.ts
Line 4 in 040589a
@Tobbe this may not be the end of it—in those environments, there's no
redwood.tomleither, so I thinkgetConfigwill throw. But we can solve one bug at a time.