fix(graphql-server): Move yoga creation to avoid creation on every request #9039
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
approved these changes
Aug 14, 2023
There was a problem hiding this comment.
Approved.
When I implemented the create Yoga refactor, I thought Yoga create and makeMergedSchema happened per request -- which it does.
However, my implementation didn't account for the way lambdas after cold start etc can be reused such that makeMergedSchema doesn't happen on each request handler.
My moving the creation into the handler I told it to makeMergedSchema every request handle -- every time -- regardless of lambda reuse.
Thus a large performance hit.
Many thanks to @Josh-Walker-GM for helping debug this as we stepped through changes.
thedavidprice
pushed a commit
that referenced
this pull request
Aug 15, 2023
…quest (#9039) **Problem** v6 has seen some performance issues. These appear to have sneaked in on #8339. This just reverts the change by moving the creation of the yoga object so that it isn't created on every request. **Changes** 1. Moves yoga creation. **Outstanding** 1. We still have a tiny bit of work to do analysing a slight performance decline since 4.4.3
thedavidprice
pushed a commit
that referenced
this pull request
Aug 17, 2023
…quest (#9039) **Problem** v6 has seen some performance issues. These appear to have sneaked in on #8339. This just reverts the change by moving the creation of the yoga object so that it isn't created on every request. **Changes** 1. Moves yoga creation. **Outstanding** 1. We still have a tiny bit of work to do analysing a slight performance decline since 4.4.3
thedavidprice
pushed a commit
that referenced
this pull request
Aug 17, 2023
…quest (#9039) **Problem** v6 has seen some performance issues. These appear to have sneaked in on #8339. This just reverts the change by moving the creation of the yoga object so that it isn't created on every request. **Changes** 1. Moves yoga creation. **Outstanding** 1. We still have a tiny bit of work to do analysing a slight performance decline since 4.4.3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
v6 has seen some performance issues. These appear to have sneaked in on #8339. This just reverts the change by moving the creation of the yoga object so that it isn't created on every request.
Changes
Outstanding