Fix context in directive tests #9025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dthyresson
approved these changes
Aug 9, 2023
thedavidprice
pushed a commit
that referenced
this pull request
Aug 9, 2023
**Problem** Context isolation was not behaving as expect when using directive tests. See https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/46 for more details. **Changes** 1. We set the global context to match the context passed in to the `mockRedwoodDirective` and then the mock directive gets the global context during execution. **Notes** It looks like in v5 we didn't pass through the context that was provided as a parameter to `mockRedwoodDirective`. It can be somewhat tricky to understand exactly what is happening due to a few layers and that in <v6 the context was not isolated between tests. **Outstanding** 1. People may not fully expect the side effect that passing in the context to the mock directive sets the global context?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Context isolation was not behaving as expect when using directive tests. See https://community.redwoodjs.com/t/redwood-v6-0-0-upgrade-guide/5044/46 for more details.
Changes
mockRedwoodDirectiveand then the mock directive gets the global context during execution.Notes
It looks like in v5 we didn't pass through the context that was provided as a parameter to
mockRedwoodDirective. It can be somewhat tricky to understand exactly what is happening due to a few layers and that in <v6 the context was not isolated between tests.Outstanding