docs(services): fix numericality validation example #8892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtoar
approved these changes
Jul 13, 2023
jtoar
pushed a commit
that referenced
this pull request
Jul 17, 2023
In the `numericality` validation example, the object `{ otherThan: 13,
'You cannot go to floor ${otherThan}' }` seems to be incorrect, and
according to the context I believe the best fix would be adding the
`message` key to it.
I added the `Floor` label to maintain consistency with other examples,
but I'm aware it may not be needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the
numericalityvalidation example, the object{ otherThan: 13, 'You cannot go to floor ${otherThan}' }seems to be incorrect, and according to the context I believe the best fix would be adding themessagekey to it.I added the
Floorlabel to maintain consistency with other examples, but I'm aware it may not be needed.