Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRWA: --yes #8870

Merged
merged 6 commits into from
Jul 13, 2023
Merged

CRWA: --yes #8870

merged 6 commits into from
Jul 13, 2023

Conversation

Tobbe
Copy link
Member

@Tobbe Tobbe commented Jul 9, 2023

A lot of CLIs accept a --yes or -y flag to accept all defaults.

Some examples includes: yarn init -y, npm init -y, apt-get -y install <package>

There's even a unix command that tries to do this for commands that don't support that flag. It's called yes https://linux.die.net/man/1/yes

But, as the wikipedia page for yes says:

This usage may be obsolete today, as most commands that would request response from the user have either a 'force' option (e.g., rm -f) or an 'assume-yes' option (for example, apt -y)

I think we should support -y for create-redwood-app. This PR adds that.

EDIT:
Additional note: You can still override a specific setting. Like yarn create redwood-app --no-git-init --yes to not initialize a git repo

@Tobbe Tobbe requested review from jtoar and ahaywood July 9, 2023 18:39
@Tobbe Tobbe added the release:feature This PR introduces a new feature label Jul 9, 2023
@Tobbe Tobbe modified the milestones: next-release, v6.0.0 Jul 9, 2023
Copy link
Contributor

@jtoar jtoar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great for me, and the idea seems sensible, especially for us for testing, though it's certainly useful for users too

@Tobbe Tobbe enabled auto-merge (squash) July 13, 2023 20:08
@Tobbe Tobbe merged commit 2a92ac3 into redwoodjs:main Jul 13, 2023
27 checks passed
@Tobbe Tobbe deleted the tobbe-crwa-yes branch July 13, 2023 20:59
jtoar pushed a commit that referenced this pull request Jul 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:feature This PR introduces a new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants