-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs(vite): Remove references to webpack, and more docs on SVGs and fonts #8707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace with Vite instructions
dac09
added
release:docs
This PR only updates docs
fixture-ok
Override the test project fixture check
labels
Jun 23, 2023
…s/webpack-refs * 'docs/webpack-refs' of github.com:dac09/redwood: fix(deps): update dependency @whatwg-node/fetch to v0.9.7 (redwoodjs#8702)
dac09
changed the title
docs(vite): Remove references to webpack
docs(vite): Remove references to webpack, and more docs on SVGs and fonts
Jun 23, 2023
Tobbe
reviewed
Jun 24, 2023
Great tone in all these docs Danny! Well written 🖊️ As always, feel free to challenge all my review comments 🙂 |
dac09
commented
Jun 26, 2023
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Co-authored-by: Tobbe Lundberg <tobbe@tlundberg.com>
Tobbe
approved these changes
Jun 26, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Docs changes only!
@font-face
rules