chore(tasks): Benchmark tests #8578
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Josh-Walker-GM
added
the
release:chore
Josh-Walker-GM
force-pushed
the
jgmw-tasks/benchmark-test
branch
from
e6ffbca
to
20a8b0b
Compare
They are not needed here at all.
|
@dthyresson Let me know if this roughly matched what you thought it would be. Definitely local tool only for the time being but it can become something that can work in CI too in the future. |
Josh-Walker-GM
commented
Aug 31, 2023
dthyresson
approved these changes
Sep 6, 2023
There was a problem hiding this comment.
LGTM. Next steps are to work with @jtoar or others and consider how to run in CI.
jtoar
pushed a commit
that referenced
this pull request
Nov 2, 2023
Adds `yarn benchmark` which runs a series of k6 tests against the api server (api serve). This local tool should make it easier to catch failures or bad performance which show only when under load. If you've refactored api side code then you can run this task against main and then against your branch to check for any obvious performance or correctness regressions. This essentially does the following: * Creates a new temp. redwood project like e2e testing * Sets up a specific state of the project as defined by various setup scripts * Runs a series of k6 tests in those specifically setup environments What this doesn't do: * Handle testing different serving both dev, serve, etc. Ideally in the future this can be adapted for use in CI too so that PR's are automatically tested. This will also allow us to identify trends in performance.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
yarn benchmarkwhich runs a series of k6 tests against the api server (api serve).This local tool should make it easier to catch failures or bad performance which show only when under load. If you've refactored api side code then you can run this task against main and then against your branch to check for any obvious performance or correctness regressions.
This essentially does the following:
What this doesn't do:
Ideally in the future this can be adapted for use in CI too so that PR's are automatically tested. This will also allow us to identify trends in performance.