Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(forms): disable webpack-dev-server overlay #8298

Merged
merged 3 commits into from
May 11, 2023

Conversation

jtoar
Copy link
Contributor

@jtoar jtoar commented May 11, 2023

Fixes https://community.redwoodjs.com/t/tutorial-email-server-validation-shows-a-runtime-error-coming-from-apollo/4883.

The issue has nothing to do with @apollo/client; it's webpack-dev-server v4.15.0 which added and enabled the runtimeErrors overlay which interferes with our form error handling.

See:

@jtoar jtoar added the release:fix This PR is a fix label May 11, 2023
@jtoar jtoar added this to the next-release-patch milestone May 11, 2023
@thedavidprice
Copy link
Contributor

Great find @jtoar 🚀

@jtoar jtoar merged commit 8564995 into main May 11, 2023
@jtoar jtoar deleted the ds-fix-webpack-runtime-error-overlays branch May 11, 2023 22:35
jtoar added a commit that referenced this pull request May 11, 2023
* fix(forms): disable webpack-dev-server overlay

* reset all to defaults

* revert to just runtimeErrors
@jtoar jtoar modified the milestones: next-release-patch, v5.1.3 May 11, 2023
jtoar added a commit that referenced this pull request May 11, 2023
* fix(forms): disable webpack-dev-server overlay

* reset all to defaults

* revert to just runtimeErrors
dac09 added a commit to dac09/redwood that referenced this pull request May 12, 2023
…te-default

* 'main' of github.com:redwoodjs/redwood: (23 commits)
  fix: remove react 17/18 warning (redwoodjs#8300)
  chore(release): tolerate lerna publish faliure
  Recover lost connection (redwoodjs#8284)
  chore(deps): update dependency @faker-js/faker to v8 (redwoodjs#8296)
  chore(release): better git commits during release
  feat: experimental - Studio Overview and Performance Widgets (redwoodjs#8292)
  fix(forms): disable webpack-dev-server overlay (redwoodjs#8298)
  Fix studio lint warning (redwoodjs#8297)
  Fastify server: Default to localhost (redwoodjs#8019)
  Fix GraphQL proxy in dev environments without IPv6 (redwoodjs#8233)
  fix(deps): update dependency @graphiql/plugin-explorer to v0.1.18 (redwoodjs#8290)
  chore(deps): update dependency supertokens-auth-react to v0.32.3 (redwoodjs#8289)
  Add `setup sentry` command (redwoodjs#7790)
  chore: readme update core team and all contributors (redwoodjs#8288)
  fix(deps): update nivo monorepo to ^0.83.0 (redwoodjs#8286)
  fix(deps): update dependency babel-plugin-polyfill-corejs3 to v0.8.1 (redwoodjs#8281)
  chore(deps): update dependency @replayio/playwright to v0.3.30 (redwoodjs#8282)
  fix(deps): update dependency webpack to v5.82.1 (redwoodjs#8283)
  Add epilogue to builders (redwoodjs#8285)
  feat(studio): v2 studio (redwoodjs#8173)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix This PR is a fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants