-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: move CLI exp setup
to exp setup-opentelemetry
#8256
Conversation
19 replays were recorded for e78b1d9. 19 PassedrequireAuth graphql checks
|
I'll review now. I didn't have any high-level plans when I did the initial setup of the |
packages/cli/src/commands/experimental/setupOpentelemetryHandler.js
Outdated
Show resolved
Hide resolved
packages/cli/src/commands/experimental/setupOpentelemetryHandler.js
Outdated
Show resolved
Hide resolved
Roger that. This is meant to be iterative. And I think we can resolve better overall via a different approach — tbd when we meet this week. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I'll update the forum post if you like. Looks to me like the only change needed is to the command name?
Correct! And thank you |
* move `exp setup` to `exp setup-opentelemetry` * Add alias to docs * fix commented-out packages --------- Co-authored-by: Josh-Walker-GM <56300765+Josh-Walker-GM@users.noreply.github.com>
I'm flattening the command structure
exp setup [command]
to improve discoverability. This is part 1 of a few more steps coming, which will make handling experimental packages and setup more feasible.@Josh-Walker-GM Please do review and let me know your thoughts. NOTE: the Forum post instructions will need updating. I'm happy to do so — just let me know: https://community.redwoodjs.com/t/opentelemetry-support-experimental/4772