Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(cli): Create and report UID #8187

Merged
merged 2 commits into from
May 1, 2023
Merged

Conversation

Josh-Walker-GM
Copy link
Collaborator

Create the UID at install time and report it within CRWA telemetry.

Ping: @jtoar as discussed with @thedavidprice

@Josh-Walker-GM Josh-Walker-GM added the release:chore This PR is a chore (means nothing for users) label May 1, 2023
@Josh-Walker-GM Josh-Walker-GM requested a review from jtoar May 1, 2023 22:35
@replay-io
Copy link

replay-io bot commented May 1, 2023

16 replays were recorded for 21a504a.

image 0 Failed
image 16 Passed
    requireAuth graphql checks
          ```
          locator.waitFor: Target closed
          =========================== logs ===========================
          waiting for locator('.rw-form-error-title').locator('text=You don\'t have permission to do that') to be visible
          ============================================================
          ```
        </ol>
      </details>
      <li><a href=https://app.replay.io/recording/dfded49a-ae79-4dfa-99ce-9fb82fe80792>useAuth hook, auth redirects checks</a></li>
      <li><a href=https://app.replay.io/recording/1cf1441e-eb1a-4042-aa53-9728699a1b79>Check that a specific blog post is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/cd7ba8b9-2730-4700-b32f-30c62980437d>Check that about is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/b83ac9fc-a6d8-443b-b9da-1e948029428c>Check that homepage is prerendered</a></li>
      <li><a href=https://app.replay.io/recording/ad2e11f9-a4e1-46b4-9a27-c929082a1d35>Check that meta-tags are rendering the correct dynamic data</a></li>
      <li><a href=https://app.replay.io/recording/7279d594-4df7-4c19-8a2e-303139398ede>Check that you can navigate from home page to specific blog post</a></li>
      <li><a href=https://app.replay.io/recording/29f78601-0219-4fd7-9023-ddbebae4c7d1>Waterfall prerendering (nested cells)</a></li>
      <li><a href=https://app.replay.io/recording/7eee3e84-c4d9-483a-b36d-d1339fa23eea>RBAC: Admin user should be able to delete contacts</a></li>
      <li><a href=https://app.replay.io/recording/4835fde7-439b-444d-89be-836a9aff5fee>RBAC: Should not be able to delete contact as non-admin user</a></li>
      <li><a href=https://app.replay.io/recording/49aa9d91-cef8-4a3d-ab5b-3d64f6000d19>Smoke test with dev server</a></li>
      <li><a href=https://app.replay.io/recording/a4dbbc68-5ee8-4653-9a53-46cb2fe2d18c>Smoke test with rw serve</a></li>
      <li><a href=https://app.replay.io/recording/ed06b5e9-45f2-402e-863a-06d85a5e03ac>Loads Cell mocks when Cell is nested in another story</a></li>
      <li><a href=https://app.replay.io/recording/c915c57a-f111-456a-afb2-e444d98584f5>Loads Cell Stories</a></li>
      <li><a href=https://app.replay.io/recording/b48ed643-a2e0-4b8d-be0d-727d29524fdb>Loads MDX Stories</a></li>
      <li><a href=https://app.replay.io/recording/0884767d-85a4-438d-b6c4-5bc7e4e1e3d4>Mocks current user, and updates UI while dev server is running</a></li>
      

View test run on Replay ↗︎

@Josh-Walker-GM Josh-Walker-GM merged commit b8343f5 into main May 1, 2023
@Josh-Walker-GM Josh-Walker-GM deleted the jgmw-crwa/install-uid branch May 1, 2023 23:15
@redwoodjs-bot redwoodjs-bot bot added this to the next-release milestone May 1, 2023
@thedavidprice
Copy link
Contributor

@jtoar @Josh-Walker-GM Per today's discussion, anytime we're updating CRWA package (and especially when changing deps), let's make it a practice to update the PR with new benchmarks. E.g. for this PR, what are the new updates to the benchmarks resulting from the changes here?

@jtoar
Copy link
Contributor

jtoar commented May 1, 2023

@thedavidprice package size increased by ~120kB, and I'm sure the script as a whole got slightly (probably just very slightly) slower since more code. Will run the hyperfine benchmarks again to see if it comes up as being consistently slower but may be too small of a difference to notice. (But worth checking of course!)

@thedavidprice
Copy link
Contributor

👍next time around, let's take time to come up with a boilerplate to use for reporting

@Josh-Walker-GM nudge to update the package README and script with details (which is where we should probably record changes for applicable PRs).

Thanks!

jtoar pushed a commit that referenced this pull request May 2, 2023
* Create and report UID on install

* Handle .redwood not existing
@jtoar jtoar modified the milestones: next-release, v5.1.0 May 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:chore This PR is a chore (means nothing for users)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants