-
Notifications
You must be signed in to change notification settings - Fork 991
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(cli): Create and report UID #8187
Conversation
16 replays were recorded for 21a504a. 16 PassedrequireAuth graphql checks
|
@jtoar @Josh-Walker-GM Per today's discussion, anytime we're updating CRWA package (and especially when changing deps), let's make it a practice to update the PR with new benchmarks. E.g. for this PR, what are the new updates to the benchmarks resulting from the changes here? |
@thedavidprice package size increased by ~120kB, and I'm sure the script as a whole got slightly (probably just very slightly) slower since more code. Will run the hyperfine benchmarks again to see if it comes up as being consistently slower but may be too small of a difference to notice. (But worth checking of course!) |
👍next time around, let's take time to come up with a boilerplate to use for reporting @Josh-Walker-GM nudge to update the package README and script with details (which is where we should probably record changes for applicable PRs). Thanks! |
* Create and report UID on install * Handle .redwood not existing
Create the UID at install time and report it within CRWA telemetry.
Ping: @jtoar as discussed with @thedavidprice